Release name template#602
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom May 30, 2018
Merged
Conversation
afrittoli
requested review from
dgageot,
dlorenc,
r2d4 and
viglesiasce
as code owners
Contributor
|
@afrittoli Thanks for the PR. The linter is complaining |
afrittoli
force-pushed
the
release_name_template
branch
3 times, most recently
from
d62dbdd to
fd88bc8
Compare
Contributor
Author
afrittoli
force-pushed
the
release_name_template
branch
2 times, most recently
from
7ae8bb9 to
3ebbe0b
Compare
Contributor
Author
|
I checked the corporate CLA and it in facts it includes "Grant of Copyright License" in point (2) of https://cla.developers.google.com/about/google-corporate. I reverted the copyright statements to Google, and replaced a couple of spaces for a tab, and now the linter is happy. |
afrittoli
force-pushed
the
release_name_template
branch
from
3ebbe0b to
d791681
Compare
When using skaffold in CI, it would be handy to be able to deploy to a shared cluster. To do that the current options are either to change skaffold.yaml during the CI job (e.g. using sed) or to limit CI jobs to one at the time for a specific repo/skaffold.yaml. Templating the release name allows to bind the release name to change metadata like a PR number. Adding tests for util/env_template.go which I prepared for refactor PR and missed to add into the PR. Signed-off-by: Andrea Frittoli (andreaf) <andrea.frittoli@uk.ibm.com>
afrittoli
force-pushed
the
release_name_template
branch
from
d791681 to
9fe0967
Compare
Contributor
|
LGTM |
dgageot
approved these changes
May 30, 2018
Contributor
|
Can I have some example containing how to use it? |
Contributor
|
Nevermind, got it. helm:
releases:
- name: "{{.APP_NAME}}-{{.APP_ENV}}" |
mtreinish
pushed a commit
to mtreinish/health-helm
that referenced
this pull request
Nov 8, 2018
For CI, each PR should deploy to a different release name at least. This depends on GoogleContainerTools/skaffold#602 which is not merged yet in skaffold. Add ingress as well, so that the cluster deployed via CI can be accessed via a public URL. For simplicity for now I assume everything is in the default namespace and so to avoid conflict between releases I defined a release specific path. The ingress configuration are a simplified version of what "helm create" would create. Eventually it would be good to move annotations and paths back into values to make it possible to run this chart on a ingress implementation other then the IKS custom one. In future we could use per-ci-build (i.e. per-release) sub-domains and a fixed path to access api and dashboard, but that requires some extra work especially if we want to enable TLS as well (which we should). See https://console.bluemix.net/docs/containers/cs_ingress.html#ingress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to express the release name as a template.
This is based on #601