cmd: add skaffold deploy#624
Merged
r2d4 merged 1 commit intoGoogleContainerTools:masterfrom Jun 1, 2018
Merged
Conversation
Contributor
Author
|
fixes #35 |
Contributor
Author
|
ref #625 |
jonjohnsonjr
reviewed
Jun 1, 2018
| }, | ||
| } | ||
| AddRunDevFlags(cmd) | ||
| cmd.Flags().StringSliceVar(&images, "images", nil, "A list of images to deploy") |
Contributor
There was a problem hiding this comment.
Any reason not to make these args instead of a flag?
Contributor
Author
There was a problem hiding this comment.
If they are args we can't have any more nested subcommands. Not really planning any now but thats been confusing in the past.
dgageot
approved these changes
Jun 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I might be able to get rid of some of the redundancy in the build struct - it shouldn't really need anything other than the full image tag. Now that we have go-containerregistry, it becomes a lot easier to separate the parts (tag/context)