adds helper script for release notes#662
Merged
r2d4 merged 2 commits intoGoogleContainerTools:masterfrom Jun 11, 2018
Merged
Conversation
balopat
requested review from
dgageot,
dlorenc,
r2d4 and
viglesiasce
as code owners
balopat
force-pushed
the
improve_release_process
branch
from
5215f95 to
ad4e4f4
Compare
Contributor
Author
|
hmmm...I'm not sure how we want to manage dependencies of utilities written in go. Should I just simple add it to vendor, is that the recommended approach? |
balopat
force-pushed
the
improve_release_process
branch
from
ad4e4f4 to
d6fd69d
Compare
r2d4
approved these changes
Jun 11, 2018
hack/release_notes.sh
Outdated
| # a simple little utility to list PRs for release notes: | ||
| # Run ./hack/release_notes.sh --help for more info | ||
|
|
||
| go get github.com/google/go-github/github |
Contributor
There was a problem hiding this comment.
shouldn't need this since its vendored
Contributor
Author
There was a problem hiding this comment.
right, forgot about that. Good catch!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for our convenience: