Merged
Conversation
dgageot
force-pushed
the
fix-705
branch
2 times, most recently
from
f39cbe7 to
a3d10d6
Compare
dgageot
force-pushed
the
fix-705
branch
9 times, most recently
from
485b0d1 to
f0831da
Compare
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
mattkelly
reviewed
Jun 25, 2018
pkg/skaffold/build/tag/git_commit.go
Outdated
| for _, changedPath := range changes { | ||
| status := status[changedPath].Worktree | ||
| lines = append(lines, fmt.Sprintf("%c %s", status, changedPath)) | ||
| func nornalizePath(path string) (string, error) { |
In that case, use the digest Fix GoogleContainerTools#663
r2d4
approved these changes
Jun 25, 2018
| @@ -57,36 +53,44 @@ func (c *GitCommit) GenerateFullyQualifiedImageName(workingDir string, opts *Opt | |||
| func generateNameGitShellOut(workingDir string, opts *Options) (string, error) { | |||
Contributor
There was a problem hiding this comment.
Now that we're adding some more logic to git-shell impl, are we always going to get the same result with git-shell vs. go-git? Do we care? Should we just drop the library?
Contributor
Author
There was a problem hiding this comment.
The same features should be implemented by both paths. Both paths are also tested. If that’s not the case, it’s an error
| return lines, nil | ||
| } | ||
|
|
||
| func commitOrTag(currentTag string, tags []string, opts *Options) string { |
Contributor
There was a problem hiding this comment.
why does this need a slice of tags?
Can git describe --tags --always return more than one tag?
$ git tag test
$ git tag test2
$ git describe --tags --always
test
Contributor
Author
There was a problem hiding this comment.
Go-git returns a slice. Don’t know why
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the git tagger more useable in real world situations: