Improve Kaniko code and ns handling#722
Merged
r2d4 merged 2 commits intoGoogleContainerTools:masterfrom Jun 21, 2018
Merged
Conversation
Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#717 Signed-off-by: David Gageot <david@gageot.net>
r2d4
reviewed
Jun 21, 2018
examples/kaniko/skaffold.yaml
Outdated
| gcsBucket: skaffold-kaniko | ||
| pullSecretName: e2esecret | ||
| namespace: default | ||
| # namespace: default |
Contributor
There was a problem hiding this comment.
The way the test was implemented won't make this work. It reuses a secret in the default namespace instead of create one. What we should really do is use the original codepath and provide the secret file that skaffold will use to create/delete the secret everytime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.