Skip to content

Support docker build --cache-from#737

Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot:cache-from
Jun 25, 2018
Merged

Support docker build --cache-from#737
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot:cache-from

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Jun 24, 2018

No description provided.

@dgageot dgageot force-pushed the cache-from branch 2 times, most recently from ccd81c0 to 9bf08ef Compare June 25, 2018 05:06
dgageot added 2 commits June 25, 2018 22:42
Fixes GoogleContainerTools#701

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@balopat balopat self-assigned this Jun 25, 2018
Copy link
Copy Markdown
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@balopat
Copy link
Copy Markdown
Contributor

balopat commented Jun 25, 2018

I did think a little bit about keeping the BuildOptions around but I guess you're right to get rid of it - if there are skaffold specific image building options we can reintroduce a narrower interface + the output buffer really doesn't have to belong there.

@dgageot
Copy link
Copy Markdown
Contributor Author

dgageot commented Jun 25, 2018

@balopat Thanks for your time!

@dgageot dgageot merged commit e596794 into GoogleContainerTools:master Jun 25, 2018
@dgageot dgageot deleted the cache-from branch December 28, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants