Don’t always fail if some COPY patterns don't match any file#744
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Jun 25, 2018
Merged
Don’t always fail if some COPY patterns don't match any file#744dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Docker does not seem to mind if a wildcard matches no files so long as there is at least one file found on the statement to copy. Fixes GoogleContainerTools#741 Signed-off-by: David Gageot <david@gageot.net>
nkubala
reviewed
Jun 25, 2018
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
Should we warn the user that wildcard pattern *.whatever didn't match any files, so it's a noop? A silent failure could be potentially frustrating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker does not seem to mind if a wildcard matches no files so long as there is at least one file found on the statement to copy.
Fixes #741
Signed-off-by: David Gageot david@gageot.net