Fix dev loop

[dgageot]

• Don't exit if deploy fails after the first time
• Run the cleanup after a build or deploy error on first run

Fixes #747, #746

[nkubala]

I think this is getting deferred before we enter the dev loop, does it matter that the cancel function might get called twice?

[dgageot]

It’s ok. It can be cancelled multiple times. Only the first time is useful Le mer. 27 juin 2018 à 18:54, Nick Kubala <notifications@github.com> a écrit :

…

***@***.**** commented on this pull request. ------------------------------ In cmd/skaffold/app/cmd/dev.go <#758 (comment)> : > @@ -85,7 +85,10 @@ func devLoop(ctx context.Context, out io.Writer, filename string) error { ctxDev, cancelDev := context.WithCancel(ctx) c <- cancelDev if err := runDev(ctxDev, out, filename); err != nil { - logrus.Warnln("dev:", err) + logrus.Errorln("dev:", err) + cancelMainLoop() I think this is getting deferred before we enter the dev loop, does it matter that the cancel function might get called twice? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#758 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJXl6PXWwottbYOdjwF2HLb-PZ2BRi-ks5uA7jUgaJpZM4U5QjK> .