add support for helm image convention vs fqn setting#826
Merged
r2d4 merged 6 commits intoGoogleContainerTools:masterfrom Jul 30, 2018
Merged
add support for helm image convention vs fqn setting#826r2d4 merged 6 commits intoGoogleContainerTools:masterfrom
r2d4 merged 6 commits intoGoogleContainerTools:masterfrom
Conversation
Contributor
|
Could we please see another release (9.1?) when this is merged! |
Contributor
Contributor
Author
|
@r2d4 Wouldn't it be better to default to the helm convention? I can fix the example to match the new default. I'm aware it will be a breaking change but it will support a much wider range of Helm charts. |
Contributor
|
I don't want to break users current config, even if its really the right behavior. What do you think about leaving the default behavior as is for now, and then we can merge the feature, try it out, and migrate to |
Contributor
|
We can even use |
Contributor
Author
|
You're right. Better roll it slow and only enable for users who try the new version. I'll update the behavior accordingly. |
Contributor
Author
r2d4
approved these changes
Jul 30, 2018
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the issue described in #360
It will enable the user to determine if the image setup schema is using fully qualified named vs the Helm standard of
image.repositoryandimage.tag