fix: correct issue where skaffold setTemplateValues env vars were in some cases empty#8261
Merged
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom Dec 20, 2022
Merged
Conversation
b671b51 to
86332ac
Compare
Codecov Report
@@ Coverage Diff @@
## main #8261 +/- ##
==========================================
- Coverage 70.48% 66.12% -4.37%
==========================================
Files 515 601 +86
Lines 23150 29491 +6341
==========================================
+ Hits 16317 19500 +3183
- Misses 5776 8529 +2753
- Partials 1057 1462 +405
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
86332ac to
ffde9c0
Compare
0bb6ae5 to
f7de7e2
Compare
d24be07 to
1e3826d
Compare
1e3826d to
b359e60
Compare
ericzzzzzzz
approved these changes
Dec 20, 2022
aaron-prindle
added a commit
to aaron-prindle/skaffold
that referenced
this pull request
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8252
fixes #8260
fixes #8262
requirement for v2.0.4 release