Skip to content

fix: resolve issue where skaffold always added namespace to rendered manifests#8312

Merged
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
aaron-prindle:fix-8186
Jan 11, 2023
Merged

fix: resolve issue where skaffold always added namespace to rendered manifests#8312
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
aaron-prindle:fix-8186

Conversation

@aaron-prindle
Copy link
Copy Markdown
Contributor

@aaron-prindle aaron-prindle commented Jan 10, 2023

fixes #8186
reverts #8124

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 10, 2023

Codecov Report

Merging #8312 (5501bb0) into main (290280e) will decrease coverage by 4.43%.
The diff coverage is 54.96%.

@@            Coverage Diff             @@
##             main    #8312      +/-   ##
==========================================
- Coverage   70.48%   66.05%   -4.44%     
==========================================
  Files         515      603      +88     
  Lines       23150    29561    +6411     
==========================================
+ Hits        16317    19526    +3209     
- Misses       5776     8569    +2793     
- Partials     1057     1466     +409     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 413 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle merged commit 8d655cd into GoogleContainerTools:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[regression] Skaffold @ HEAD (in no releases) currently adds a namespace to all rendered manifests

2 participants