Skip to content

fix: use new URL format for Google Cloud Build log#8323

Merged
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
shuuji3:patch-1
Jan 16, 2023
Merged

fix: use new URL format for Google Cloud Build log#8323
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
shuuji3:patch-1

Conversation

@shuuji3
Copy link
Copy Markdown
Contributor

@shuuji3 shuuji3 commented Jan 14, 2023

Fixes: #8322
Related: N/A
Merge before/after: N/A

Description

As written in #8322, URL format https://console.cloud.google.com/m/cloudstorage/b/<bucket-name>/o/<object-name> has been deprecated so we need to use the new format https://storage.cloud.google.com/<bucket-name>/<object-name> instead.

User facing changes

This will replace the invalid deprecated log URL with the valid log URL.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 15, 2023

Codecov Report

Merging #8323 (89183d3) into main (290280e) will decrease coverage by 4.39%.
The diff coverage is 54.85%.

@@            Coverage Diff             @@
##             main    #8323      +/-   ##
==========================================
- Coverage   70.48%   66.08%   -4.40%     
==========================================
  Files         515      605      +90     
  Lines       23150    29654    +6504     
==========================================
+ Hits        16317    19597    +3280     
- Misses       5776     8588    +2812     
- Partials     1057     1469     +412     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 414 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix here!

@aaron-prindle aaron-prindle merged commit af7bd1f into GoogleContainerTools:main Jan 16, 2023
@shuuji3 shuuji3 deleted the patch-1 branch January 16, 2023 02:12
@shuuji3
Copy link
Copy Markdown
Contributor Author

shuuji3 commented Jan 16, 2023

Thanks for reviewing! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong log URL is shown

2 participants