fix: use new URL format for Google Cloud Build log#8323
Merged
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom Jan 16, 2023
Merged
fix: use new URL format for Google Cloud Build log#8323aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8323 +/- ##
==========================================
- Coverage 70.48% 66.08% -4.40%
==========================================
Files 515 605 +90
Lines 23150 29654 +6504
==========================================
+ Hits 16317 19597 +3280
- Misses 5776 8588 +2812
- Partials 1057 1469 +412
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aaron-prindle
approved these changes
Jan 16, 2023
Contributor
aaron-prindle
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix here!
Contributor
Author
|
Thanks for reviewing! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8322
Related: N/A
Merge before/after: N/A
Description
As written in #8322, URL format
https://console.cloud.google.com/m/cloudstorage/b/<bucket-name>/o/<object-name>has been deprecated so we need to use the new formathttps://storage.cloud.google.com/<bucket-name>/<object-name>instead.User facing changes
This will replace the invalid deprecated log URL with the valid log URL.