Watch mode 4th edition#833
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Aug 6, 2018
Merged
Conversation
Contributor
|
Some weird behavior I encountered
|
dgageot
force-pushed
the
watch
branch
4 times, most recently
from
a7efdea to
08f79b9
Compare
Contributor
Author
|
@r2d4 I'm going to fix the code for the microservices example |
Contributor
Author
|
I'm waiting to #854 to be merged to rebase this code on top and fix the issue with the microservices example |
dgageot
force-pushed
the
watch
branch
5 times, most recently
from
c61f0f6 to
36eedee
Compare
+ Shorter code + Can detect new deployment files + Won’t stat the files that are not used by the artifacts Signed-off-by: David Gageot <david@gageot.net>
r2d4
approved these changes
Aug 6, 2018
Contributor
Author
|
\o/ Thanks for the review @r2d4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's yet another rewrite of the watch code!
Should fix #729 and #620
Signed-off-by: David Gageot david@gageot.net