feat: add ingore-path kaniko flag support#8340
Merged
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom Jan 20, 2023
Merged
feat: add ingore-path kaniko flag support#8340aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## main #8340 +/- ##
==========================================
- Coverage 70.48% 66.09% -4.40%
==========================================
Files 515 605 +90
Lines 23150 29658 +6508
==========================================
+ Hits 16317 19601 +3284
- Misses 5776 8588 +2812
- Partials 1057 1469 +412
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aaron-prindle
approved these changes
Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: GoogleContainerTools/kaniko#2164
Description
For local development we are using skaffold. Also, as we are from Ukraine and there could be no elictricty or no internet we need to be able to working offline. For such purposes we have created a script which ups the kind cluster and we can continue working on.
On mac based systems we don't have any issues with kind and kaniko.
But unfortunately on linux machines we have a similar issue as in linked kaniko issue.
So we need to add such flag to kaniko.
User facing changes
Ability to add an ingore paths for kaniko.