Skip to content

fix: change log level to Info so skaffold render --output=render.yaml produces same output as skaffold render &> render.yaml#8341

Merged
renzodavid9 merged 1 commit intomainfrom
issue-8327-v2
Feb 13, 2023
Merged

fix: change log level to Info so skaffold render --output=render.yaml produces same output as skaffold render &> render.yaml#8341
renzodavid9 merged 1 commit intomainfrom
issue-8327-v2

Conversation

@renzodavid9
Copy link
Copy Markdown
Contributor

@renzodavid9 renzodavid9 commented Jan 19, 2023

Related: #8327

Description
Related with #8327 , this change is for v2 to have the same output when we run skaffold render --output=render.yaml and skaffold render &> render.yaml

…l` produces same output as `skaffold render &> render.yaml` for helm with OCI registry
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2023

Codecov Report

Merging #8341 (d7ce4b2) into main (290280e) will decrease coverage by 4.40%.
The diff coverage is 54.85%.

@@            Coverage Diff             @@
##             main    #8341      +/-   ##
==========================================
- Coverage   70.48%   66.09%   -4.40%     
==========================================
  Files         515      605      +90     
  Lines       23150    29654    +6504     
==========================================
+ Hits        16317    19599    +3282     
- Misses       5776     8587    +2811     
- Partials     1057     1468     +411     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 414 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 marked this pull request as ready for review January 19, 2023 22:21
@renzodavid9 renzodavid9 requested review from a team, aaron-prindle and cloud-deploy-bot and removed request for a team and cloud-deploy-bot January 19, 2023 22:21
@renzodavid9 renzodavid9 merged commit 447b509 into main Feb 13, 2023
@renzodavid9 renzodavid9 deleted the issue-8327-v2 branch February 13, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants