test: integration test for helm render with OCI repo#8352
Merged
aaron-prindle merged 1 commit intomainfrom Jan 23, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Related PR from v1:
Description
This is to test the render command with a helm chart located in a OCI repository. Using skaffold with helm >= 3.10.2, injects some corrupted data in the generated yaml file, this was already fixed, but an integration test to validate the behavior was missing.
A helm chart was created and uploaded to
us-central1-docker.pkg.dev/k8s-skaffold/testing/skaffold-helm-chart; to be able to run the test we need this chart.