docs: Upgrade hugo and docsy versions to enable collapsible nav#8398
Merged
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom Feb 1, 2023
Merged
docs: Upgrade hugo and docsy versions to enable collapsible nav#8398aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
Conversation
aaron-prindle
approved these changes
Feb 1, 2023
Contributor
aaron-prindle
left a comment
There was a problem hiding this comment.
Awesome, great idea to add this! Just tried it locally works great. LGTM!
Codecov Report
@@ Coverage Diff @@
## main #8398 +/- ##
==========================================
- Coverage 70.48% 65.88% -4.60%
==========================================
Files 515 605 +90
Lines 23150 29819 +6669
==========================================
+ Hits 16317 19646 +3329
- Misses 5776 8700 +2924
- Partials 1057 1473 +416
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8389
Description
Docsy now supports collapsing/expanding menu options (https://www.docsy.dev/docs/adding-content/navigation/#section-menu-options), which improves the navigability of skaffold.dev documentation. (See https://kubernetes.io/docs/home/ nav as an example.)
Before breaking up the Builders page into sub-pages (#8382), I wanted to ensure that sections were collapsible because the Build nav menu already has many sub-pages. 😄
This PR:
sidebar_menu_foldable = trueto config.toml.User facing changes
Before:
After: