refactor: replace 4d63.com/tz with time/tzdata#8408
Merged
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom Feb 6, 2023
Merged
Conversation
aaron-prindle
approved these changes
Feb 6, 2023
Contributor
aaron-prindle
left a comment
There was a problem hiding this comment.
@pmalek thanks for the PR here, LGTM! The tests you updated should be enough here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Looking at https://github.com/leighmcculloch/go-tz (
4d63.com/tzimport pathskaffold/go.mod
Line 32 in aa6f5a3
This PR replaces usage of that package with
time/tzdataby include a build tagtimetzdataas suggested at https://pkg.go.dev/time/tzdata. An alternative is to importtime/tzdataas suggested:Open questions
Tests at https://github.com/GoogleContainerTools/skaffold/blob/main/pkg/skaffold/tag/date_time_test.go seem to pass (at least locally). Do we want to include more for this change?