chore: upgrade dependencies#8431
Conversation
| }, | ||
| sdktrace.WithSampler(sdktrace.AlwaysSample()), | ||
| ) | ||
| exporter, err := texporter.New() |
There was a problem hiding this comment.
this method has already handled default credential fetching.
Codecov Report
@@ Coverage Diff @@
## main #8431 +/- ##
==========================================
- Coverage 70.48% 65.18% -5.30%
==========================================
Files 515 603 +88
Lines 23150 29902 +6752
==========================================
+ Hits 16317 19492 +3175
- Misses 5776 8934 +3158
- Partials 1057 1476 +419
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Linter tests failing related to You can download This can fixed running something like: |
Thank you! I usually run |
| func TraceEndError(err error) trace.SpanEndOption { | ||
| if traceEnabled { | ||
| return trace.WithAttributes(attribute.KeyValue{Key: "error", Value: attribute.StringValue(PII(err.Error()))}) | ||
| return trace.WithStackTrace(true) |
There was a problem hiding this comment.
now span.End takes SpanEndOption as input, however, we cannot create a SpanEndOption WithAttribute, I'd prefer to leave the code here, we can revisit that when working on exporting metrics to firelog.
Fixes: #8418
Description:
-, the previous one was aligned with its parent. Our integration tests use a lot of hard code yaml raw string comparison, the is not a good practice, we should compare the target unmarshalled object field instead, to not include a lot of changes in this pr, I only convert those raw string into object for comparison, but we can make it better.generate pipeline, it was broken after upgrade dependencies and I didn't see we use this anywhere, let me know if this is still in use.