Skip to content

chore: add krm functions to allowList#8445

Merged
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
ericzzzzzzz:add-more-krm-functions-to-allowlist
Feb 16, 2023
Merged

chore: add krm functions to allowList#8445
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
ericzzzzzzz:add-more-krm-functions-to-allowlist

Conversation

@ericzzzzzzz
Copy link
Copy Markdown
Contributor

@ericzzzzzzz ericzzzzzzz commented Feb 16, 2023

Fixes: #8189

Future Work
#8448
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

  • Add more krm functions to kpt transformAllowList based on https://catalog.kpt.dev/
  • The followings are not added
    • fix, this is for upgrading Krm file schema, it is not helpful to integrate it to skaffold render flow
    • list-setters , this is for seeing comments with setters, cannot be used to chain krm functions
    • render-helm-chart users should use manifests.helm stanza directly
    • set-image, this will override the image field in all manifests, its not suitable for skaffold flow.
    • starlark, not applicable in skaffold config
    • upsert-resource not applicatble in skaffold config

@ericzzzzzzz ericzzzzzzz requested review from a team and aaron-prindle February 16, 2023 15:24
@ericzzzzzzz ericzzzzzzz marked this pull request as draft February 16, 2023 15:25
@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review February 16, 2023 16:04
Copy link
Copy Markdown
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also create an issue tracking documenting the kpt supported fxns and their aliases?

@ericzzzzzzz ericzzzzzzz merged commit 86b2f09 into GoogleContainerTools:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update OR remove (allowing any) the allowlist of transformers available in manifests.transformers used via Kpt

2 participants