fix: expand home directory for docker secrets#8476
Merged
ericzzzzzzz merged 2 commits intoGoogleContainerTools:mainfrom Feb 24, 2023
Merged
fix: expand home directory for docker secrets#8476ericzzzzzzz merged 2 commits intoGoogleContainerTools:mainfrom
ericzzzzzzz merged 2 commits intoGoogleContainerTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## main #8476 +/- ##
==========================================
- Coverage 70.48% 65.22% -5.27%
==========================================
Files 515 602 +87
Lines 23150 29889 +6739
==========================================
+ Hits 16317 19494 +3177
- Misses 5776 8922 +3146
- Partials 1057 1473 +416
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
@ericzzzzzzz I see the issue with the test failing but not sure to understand, any help for resolving this ? |
Contributor
|
@griseau This seems like a flaky test.. just re-ran to see if the test pass. |
ericzzzzzzz
approved these changes
Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8453
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs
Description
As mentioned in the issue, when using ~/ for secret path, this wasn't expended to home directory but was happened after current directory. This change expends the path to the realpath of home directory if starting with ~/
User facing changes (remove if N/A)
No user facing changes other than have it working as intended
Follow-up Work (remove if N/A)
Should we test the util function ? It's only calling Go standard package
And thanks @smaftoul for your help on this one ;)