fix: skaffold render namespace regression in v2

[gsquared94]

Fixes: b/265799040

Description

From helm/helm#3553 helm template command run with the --namespace flag doesn't set the metadata.namespace in the rendered manifests but only sets {{.Release.Namespace}} templates. In Skaffold v1, the deploy.helm.releases[i].namespace property was also being passed as the --namespace flag for a skaffold apply command. To preserve this behavior in v2 when upgrading from an old config, the upgrade logic is changed to duplicate the deploy.helm.releases to manifests.helm.releases. So we can use the helm release namespace values again in the skaffold apply command.

[codecov]

Codecov Report

Merging #8482 (9a49100) into main (290280e) will decrease coverage by 5.28%.
The diff coverage is 55.02%.

@@            Coverage Diff             @@
##             main    #8482      +/-   ##
==========================================
- Coverage   70.48%   65.20%   -5.28%     
==========================================
  Files         515      602      +87     
  Lines       23150    29912    +6762     
==========================================
+ Hits        16317    19505    +3188     
- Misses       5776     8937    +3161     
- Partials     1057     1470     +413     

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/completion.go	13.04% <0.00%> (-1.25%)	⬇️
cmd/skaffold/app/cmd/config/list.go	65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go	88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go	54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go	100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go	0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go	40.90% <0.00%> (-12.94%)	⬇️
cmd/skaffold/app/cmd/generate_pipeline.go	60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go	65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go	66.66% <ø> (ø)
... and 425 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[aaron-prindle]

LGTM

[aaron-prindle]

LGTM, only thing that might make sense is to add a validation/error for if the namespaces are different between manifests.* and deploy.* , add an error but don't have a strong opinion.

[renzodavid9]

LGTM! We should create an issue to create an integration test for this case. I can create it if you'd like