Skip to content

Docs: Update _index.md to use more appropriate grammar#8484

Merged
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
GLStephen:patch-1
Mar 1, 2023
Merged

Docs: Update _index.md to use more appropriate grammar#8484
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
GLStephen:patch-1

Conversation

@GLStephen
Copy link
Copy Markdown
Contributor

This is just a simple grammar fix.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@GLStephen GLStephen changed the title Update _index.md Docs: Update _index.md to use more appropriate grammar Mar 1, 2023
@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf bot commented Mar 1, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@GLStephen GLStephen closed this Mar 1, 2023
@GLStephen GLStephen reopened this Mar 1, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2023

Codecov Report

Merging #8484 (cc8089a) into main (290280e) will decrease coverage by 5.27%.
The diff coverage is 55.02%.

@@            Coverage Diff             @@
##             main    #8484      +/-   ##
==========================================
- Coverage   70.48%   65.21%   -5.27%     
==========================================
  Files         515      602      +87     
  Lines       23150    29886    +6736     
==========================================
+ Hits        16317    19491    +3174     
- Misses       5776     8923    +3147     
- Partials     1057     1472     +415     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 425 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix here @GLStephen! The one failing test is around the commit message, for future information - skaffold uses the ConventionalCommit standard and has a test around commit messages having a format with a category prefix such as docs: in this case:

docs: Update _index.md to use more appropriate grammar

I can change the commit message when I merge so I can merge this, just a heads up on any future PRs. Thanks!

@aaron-prindle aaron-prindle merged commit e960406 into GoogleContainerTools:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants