Skip to content

chore: upgrade go version in skaffold image#8540

Merged
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
ericzzzzzzz:upgrade-go-version-to-v1.19.6
Mar 14, 2023
Merged

chore: upgrade go version in skaffold image#8540
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
ericzzzzzzz:upgrade-go-version-to-v1.19.6

Conversation

@ericzzzzzzz
Copy link
Copy Markdown
Contributor

@ericzzzzzzz ericzzzzzzz commented Mar 10, 2023

Fixes: #8538
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2023

Codecov Report

Merging #8540 (6cf3caa) into main (290280e) will decrease coverage by 6.12%.
The diff coverage is 54.84%.

@@            Coverage Diff             @@
##             main    #8540      +/-   ##
==========================================
- Coverage   70.48%   64.36%   -6.12%     
==========================================
  Files         515      607      +92     
  Lines       23150    30401    +7251     
==========================================
+ Hits        16317    19568    +3251     
- Misses       5776     9369    +3593     
- Partials     1057     1464     +407     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 38 more

... and 385 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle self-requested a review March 10, 2023 19:50
Copy link
Copy Markdown
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle aaron-prindle merged commit 908c36a into GoogleContainerTools:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skaffold vulnerabilities found in edge binary

2 participants