fix: improve verify command s.t. os envs not passed through to container envs and instead add a flag for this purpose#8557
Merged
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom Mar 22, 2023
Conversation
aaron-prindle
force-pushed
the
fix-7945
branch
3 times, most recently
from
f334185 to
3257d0c
Compare
Codecov Report
@@ Coverage Diff @@
## main #8557 +/- ##
==========================================
- Coverage 70.48% 64.30% -6.18%
==========================================
Files 515 608 +93
Lines 23150 30441 +7291
==========================================
+ Hits 16317 19576 +3259
- Misses 5776 9397 +3621
- Partials 1057 1468 +411
... and 386 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aaron-prindle
force-pushed
the
fix-7945
branch
2 times, most recently
from
cb8a248 to
4a19509
Compare
aaron-prindle
force-pushed
the
fix-7945
branch
3 times, most recently
from
171ff6d to
3b169a3
Compare
renzodavid9
reviewed
Mar 21, 2023
pkg/skaffold/verify/util/logfile.go
Outdated
| } | ||
|
|
||
| // WithLogFile returns a file to write the deploy output to, and a function to be executed after the deploy step is complete. | ||
| func WithLogFile(filename string, out io.Writer, muted Muted) (io.Writer, func(), error) { |
Contributor
There was a problem hiding this comment.
I think we are not using this function anywhere (except from the tests), is this something for an upcoming change? Or is ok to remove it?
…ner envs and instead add a flag for this purpose
renzodavid9
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7945