chore: enhance vuln monitor#8570
Merged
ericzzzzzzz merged 18 commits intoGoogleContainerTools:mainfrom Mar 24, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8570 +/- ##
==========================================
- Coverage 70.48% 64.32% -6.16%
==========================================
Files 515 607 +92
Lines 23150 30421 +7271
==========================================
+ Hits 16317 19568 +3251
- Misses 5776 9387 +3611
- Partials 1057 1466 +409
... and 385 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
deploy/vuln-monitor/scan.sh
Outdated
|
|
||
| set -xeo pipefail | ||
| # Variables that will be substituted by trigger configuration or valued provided through command line with --substitutions flag. | ||
| if [ -z "$_TAG_FILTER" ]; then |
Contributor
There was a problem hiding this comment.
Is the _TAG_FILTER variable used? Might make sense to delete it if not
deploy/vuln-monitor/scan.sh
Outdated
| # We should only scan lts images within 1 year window from the first patch of the release. | ||
| targeted_base_tags="$(gcloud container images list-tags "$base_image" --filter="timestamp.datetime > -P1Y AND tags~v.*\.1-lts" --format='value(tags)')" | ||
| for line in $targeted_base_tags; do | ||
| IFS=',' read -ra t <<< "${line}" |
Contributor
There was a problem hiding this comment.
nit: the other IFS call uses double quotes (","), might make sense to use consistent style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #8503
Description
one year.Test Plan
test-bin-scanningbuild trigger in skaffold project, I tested this morning and related vuls were already created by myrun, you can close some of those issues and trigger the build to see the result, this should work as the description.Monitor Frenquency
/deploy/cloudbuildanddeploy/cloudbuild-release-lts.