Skip to content

fix: Replace Kustomize field patches in examples#8757

Merged
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
halvards:kustomize-v5-patches-obsolete
May 31, 2023
Merged

fix: Replace Kustomize field patches in examples#8757
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
halvards:kustomize-v5-patches-obsolete

Conversation

@halvards
Copy link
Copy Markdown
Contributor

@halvards halvards commented May 8, 2023

This change replaces the obsolete use of the Kustomize patches field in the Skaffold examples with patchesStrategicMerge.

Context:
Kustomize v5 removed support for patches being an array of strings.

The patchesStrategicMerge field introduced in Kustomize v3 retains the previous behavior of the patches.

The patches field can still be used in v5 with an array of patch objects.

Additional information:

This change replaces the obsolete use of the Kustomize `patches` field
in the Skaffold examples with `patchesStrategicMerge`.

Context:
Kustomize v5 removed support for `patches` being an array of strings.

The `patchesStrategicMerge` field introduced in Kustomize v3 retains the
previous behavior of the `patches`.

The `patches` field can still be used in v5 with an array of `patch`
objects.

Additional information:
- kubernetes-sigs/kustomize#4911
- https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv5.0.0
@codecov
Copy link
Copy Markdown

codecov bot commented May 9, 2023

Codecov Report

Merging #8757 (243e10a) into main (290280e) will decrease coverage by 6.09%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #8757      +/-   ##
==========================================
- Coverage   70.48%   64.40%   -6.09%     
==========================================
  Files         515      617     +102     
  Lines       23150    31171    +8021     
==========================================
+ Hits        16317    20075    +3758     
- Misses       5776     9590    +3814     
- Partials     1057     1506     +449     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 406 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle added the kokoro:force-run forces a kokoro re-run on a PR label May 22, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label May 22, 2023
@ericzzzzzzz ericzzzzzzz merged commit dc65e65 into GoogleContainerTools:main May 31, 2023
@halvards halvards deleted the kustomize-v5-patches-obsolete branch June 29, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants