fix: Replace Kustomize field patches in examples#8757
Merged
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom May 31, 2023
Merged
fix: Replace Kustomize field patches in examples#8757ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
patches in examples#8757ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
Conversation
This change replaces the obsolete use of the Kustomize `patches` field in the Skaffold examples with `patchesStrategicMerge`. Context: Kustomize v5 removed support for `patches` being an array of strings. The `patchesStrategicMerge` field introduced in Kustomize v3 retains the previous behavior of the `patches`. The `patches` field can still be used in v5 with an array of `patch` objects. Additional information: - kubernetes-sigs/kustomize#4911 - https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv5.0.0
Codecov Report
@@ Coverage Diff @@
## main #8757 +/- ##
==========================================
- Coverage 70.48% 64.40% -6.09%
==========================================
Files 515 617 +102
Lines 23150 31171 +8021
==========================================
+ Hits 16317 20075 +3758
- Misses 5776 9590 +3814
- Partials 1057 1506 +449
... and 406 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ericzzzzzzz
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces the obsolete use of the Kustomize
patchesfield in the Skaffold examples withpatchesStrategicMerge.Context:
Kustomize v5 removed support for
patchesbeing an array of strings.The
patchesStrategicMergefield introduced in Kustomize v3 retains the previous behavior of thepatches.The
patchesfield can still be used in v5 with an array ofpatchobjects.Additional information: