chore: update release build script to support internal scanning#8834
Merged
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom Jun 1, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8834 +/- ##
==========================================
- Coverage 70.48% 63.94% -6.54%
==========================================
Files 515 620 +105
Lines 23150 31455 +8305
==========================================
+ Hits 16317 20115 +3798
- Misses 5776 9836 +4060
- Partials 1057 1504 +447
... and 410 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
plumpy
reviewed
Jun 1, 2023
| - 'make' | ||
| - 'release-lts' | ||
| - 'VERSION=$TAG_NAME' | ||
| - 'SCANNING_MARKER=$_SCANNING_MARKER' |
Contributor
There was a problem hiding this comment.
I don't think $_SCANNING_MARKER is defined anywhere?
Contributor
Author
plumpy
approved these changes
Jun 1, 2023
ericzzzzzzz
added a commit
to ericzzzzzzz/skaffold
that referenced
this pull request
Jun 1, 2023
This was referenced Jun 1, 2023
ericzzzzzzz
added a commit
that referenced
this pull request
Jun 2, 2023
* chore: update release build script to support internal scanning (#8834) * chore: fix test * chore: change schema check against v2.3 * chore: change schema check against v2.3 * chore: update example version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes: #7169
Related: Need to do the same for v1.39, v2.0, v2.3,
Description