Update golangci-lint to v1.9.3 and enable misspell+unparam modules#884
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Aug 7, 2018
Merged
Update golangci-lint to v1.9.3 and enable misspell+unparam modules#884dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
dlorenc
approved these changes
Aug 7, 2018
Contributor
|
@tstromberg you might want to rebase |
Alphabetized the modules for fun and profit.
Author
|
Rebased. |
balopat
approved these changes
Aug 7, 2018
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
LGTM, thank you for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires the following PR's to be submitted first to avoid test failures:
#883 "misspell" and "unparam" lint issues
#880 Add missing filename to error message