Improve file change tracking#888
Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom Aug 10, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
==========================================
- Coverage 38.38% 38.27% -0.12%
==========================================
Files 54 56 +2
Lines 2519 2576 +57
==========================================
+ Hits 967 986 +19
- Misses 1441 1476 +35
- Partials 111 114 +3
Continue to review full report at Codecov.
|
Contributor
|
@dgageot, the new tests seem to be failing, can you check? |
Contributor
Author
|
@balopat Works on my machine. lol |
e221954 to
296b526
Compare
Signed-off-by: David Gageot <david@gageot.net>
Contributor
Author
|
@balopat should be good now. Funny to see the coverage decrease when I added tests and removed some code. |
dlorenc
approved these changes
Aug 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some tests to the code that detects file changes.
Also simplifies the code used to track changes.
This should make the watch mode consume less CPU.
I'll run some tests before getting this PR merged to know how much