feat: implement skaffold delete for docker deployer using docker labels#8885
Merged
renzodavid9 merged 4 commits intoGoogleContainerTools:mainfrom Jun 26, 2023
Merged
Conversation
… containers and network
…the Docker deployer
Codecov Report
@@ Coverage Diff @@
## main #8885 +/- ##
==========================================
- Coverage 70.48% 63.60% -6.88%
==========================================
Files 515 622 +107
Lines 23150 31676 +8526
==========================================
+ Hits 16317 20148 +3831
- Misses 5776 10017 +4241
- Partials 1057 1511 +454
... and 413 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ericzzzzzzz
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #6314
Description
This PRs enables the
skaffold deletecommand when using the Docker deployer. The logic is based in the use of Docker labels to tag the different resources created during deployment with the Docker deployer.During a deployment different resources can be created by Skaffold: containers (
skaffold.yamlcontainers and debug containers), networks, volumes (when doingskaffold debug). The logic deletes the resources associated with the project where the command is running.