Skip to content

chore: port apply-setter krm function over to skaffold#8902

Merged
ericzzzzzzz merged 5 commits intoGoogleContainerTools:mainfrom
ericzzzzzzz:port-over-apply-setter-function
Jun 22, 2023
Merged

chore: port apply-setter krm function over to skaffold#8902
ericzzzzzzz merged 5 commits intoGoogleContainerTools:mainfrom
ericzzzzzzz:port-over-apply-setter-function

Conversation

@ericzzzzzzz
Copy link
Copy Markdown
Contributor

@ericzzzzzzz ericzzzzzzz commented Jun 21, 2023

Fixes: #8901

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 21, 2023

Codecov Report

Merging #8902 (0c14307) into main (290280e) will decrease coverage by 6.62%.
The diff coverage is 48.99%.

@@            Coverage Diff             @@
##             main    #8902      +/-   ##
==========================================
- Coverage   70.48%   63.86%   -6.62%     
==========================================
  Files         515      624     +109     
  Lines       23150    31793    +8643     
==========================================
+ Hits        16317    20305    +3988     
- Misses       5776     9966    +4190     
- Partials     1057     1522     +465     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 416 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Jun 21, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 21, 2023
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Jun 22, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 22, 2023
@ericzzzzzzz
Copy link
Copy Markdown
Contributor Author

it seems that kokoro job is completely broken now.

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review June 22, 2023 17:29
@ericzzzzzzz ericzzzzzzz merged commit ce682a5 into GoogleContainerTools:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

import apply-setter function to skaffold to replace kpt command call for parameterization

3 participants