feat: support tempalte parameterization for helm#8911
Merged
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom Jun 26, 2023
Merged
feat: support tempalte parameterization for helm#8911ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8911 +/- ##
==========================================
- Coverage 70.48% 63.84% -6.65%
==========================================
Files 515 624 +109
Lines 23150 31815 +8665
==========================================
+ Hits 16317 20311 +3994
- Misses 5776 9976 +4200
- Partials 1057 1528 +471
... and 415 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
kokoro ci is broken, not related to changes. |
renzodavid9
approved these changes
Jun 26, 2023
|
@ericzzzzzzz can you confirm that this should work with I'm having troubles with getting it to work: still ends up with templated value from .Values instead of the one passed through --set |
Contributor
Author
|
hi @adriantr To use template parameterization for helm
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8912
Description