Skip to content

fix: Add integration tests for helm namespace#8965

Merged
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
linjingsde:helmnamespace
Jul 22, 2023
Merged

fix: Add integration tests for helm namespace#8965
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
linjingsde:helmnamespace

Conversation

@linjingsde
Copy link
Copy Markdown
Contributor

Fixes: #8483

Description
Added integration tests related to namespaces (esp. helm release namespace setting) and v1 -> v2 schema upgrade that would expressly have caught #8185

@linjingsde linjingsde changed the title Add integration tests for helm namespace fix: Add integration tests for helm namespace Jul 21, 2023
@conventional-commit-lint-gcf
Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@renzodavid9 renzodavid9 added the kokoro:run runs the kokoro jobs on a PR label Jul 21, 2023
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jul 21, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 21, 2023

Codecov Report

Merging #8965 (4e6be7b) into main (290280e) will decrease coverage by 6.87%.
The diff coverage is 48.91%.

@@            Coverage Diff             @@
##             main    #8965      +/-   ##
==========================================
- Coverage   70.48%   63.62%   -6.87%     
==========================================
  Files         515      624     +109     
  Lines       23150    31932    +8782     
==========================================
+ Hits        16317    20316    +3999     
- Misses       5776    10085    +4309     
- Partials     1057     1531     +474     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 415 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz merged commit 26c5dea into GoogleContainerTools:main Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IntegrationTest] Add test to validate the proper helm.releases[].namespace is used on render after a schema upgrade

4 participants