feat: crd status check#9016
Merged
ericzzzzzzz merged 22 commits intoGoogleContainerTools:mainfrom Aug 22, 2023
Merged
Conversation
…e current logic for parsing hydratedManifests
Codecov Report
@@ Coverage Diff @@
## main #9016 +/- ##
==========================================
- Coverage 70.48% 63.46% -7.02%
==========================================
Files 515 624 +109
Lines 23150 32028 +8878
==========================================
+ Hits 16317 20328 +4011
- Misses 5776 10167 +4391
- Partials 1057 1533 +476
... and 416 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
renzodavid9
approved these changes
Aug 22, 2023
Contributor
|
LGTM! I was just wondering if there is a way to have the CRDs logic to manage the ConfigConnector case, I saw we are using different errors codes, but I guess we can discuss it if make sense. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8462
Description
Test Plan
skaffold/pkg/skaffold/kubernetes/manifest/selector.go
Line 62 in 700fd81
test-crds-status-check.tar.gz and untar it
skaffold dev --status-check-selectors selectors.jsonshould see status check against the crd, the status check against ConfigConnector will hang until check success, this is expected as config controller returns IN_PROGRESS for both resource reconciling and failing.