Ignore unset variables from minikube docker-env#9018
Merged
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom Aug 14, 2023
Merged
Ignore unset variables from minikube docker-env#9018ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## main #9018 +/- ##
==========================================
- Coverage 70.48% 63.62% -6.87%
==========================================
Files 515 624 +109
Lines 23150 31928 +8778
==========================================
+ Hits 16317 20313 +3996
- Misses 5776 10085 +4309
- Partials 1057 1530 +473
... and 416 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ericzzzzzzz
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In case shell is set to
none,minikube docker-envreturnsSSH_AUTH_SOCK=.This conflicts with the
SSH_AUTH_SOCKvariable set by the shell here.Effectively, this allows users to use
ssh: defaultagain when building docker containers for minikube with skaffold.