Skip to content

Fix panic in Logger.Stop#9159

Merged
renzodavid9 merged 1 commit intoGoogleContainerTools:mainfrom
mboulton-fathom:8949-fix-panic
Nov 14, 2023
Merged

Fix panic in Logger.Stop#9159
renzodavid9 merged 1 commit intoGoogleContainerTools:mainfrom
mboulton-fathom:8949-fix-panic

Conversation

@mboulton-fathom
Copy link
Copy Markdown
Contributor

Fixes: #8949

Description

There was a panic being caused in Logger.Stop() (Possibly from 97de7db) because threadLogsCancel might be nil if Stop was called before Start, this just initialises it to a noop function.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 295 lines in your changes are missing coverage. Please review.

Comparison is base (290280e) 70.48% compared to head (455b3d4) 63.74%.
Report is 1066 commits behind head on main.

Files Patch % Lines
cmd/skaffold/app/cmd/exec.go 16.32% 40 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/filter.go 47.27% 22 Missing and 7 partials ⚠️
cmd/skaffold/app/cmd/lsp.go 28.12% 23 Missing ⚠️
cmd/skaffold/app/cmd/verify.go 23.33% 23 Missing ⚠️
cmd/skaffold/app/cmd/fix.go 51.16% 17 Missing and 4 partials ⚠️
cmd/skaffold/app/cmd/inspect_job_manifest_paths.go 60.00% 15 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/inspect_namespaces.go 50.00% 13 Missing and 1 partial ⚠️
...md/skaffold/app/cmd/inspect_config_dependencies.go 45.83% 12 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/lint.go 42.85% 12 Missing ⚠️
cmd/skaffold/app/cmd/inspect_build_env.go 60.71% 11 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9159      +/-   ##
==========================================
- Coverage   70.48%   63.74%   -6.75%     
==========================================
  Files         515      630     +115     
  Lines       23150    32447    +9297     
==========================================
+ Hits        16317    20682    +4365     
- Misses       5776    10178    +4402     
- Partials     1057     1587     +530     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renzodavid9
Copy link
Copy Markdown
Contributor

Hey @mboulton-fathom, thanks for opening this PR, the change looks good. Could you please rebase the PR? That should fix the failing tests. Thanks! 😄

There was a panic being caused in Logger.Stop() (Possibly from 97de7db) because threadLogsCancel might be nil if Stop was called before Start, this just initialises it to a noop function.
@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Nov 14, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Nov 14, 2023
@renzodavid9 renzodavid9 merged commit 1f591ba into GoogleContainerTools:main Nov 14, 2023
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skaffold dev causes a panic

3 participants