Fix panic in Logger.Stop#9159
Merged
renzodavid9 merged 1 commit intoGoogleContainerTools:mainfrom Nov 14, 2023
Merged
Conversation
c6efa82 to
cc3eebf
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9159 +/- ##
==========================================
- Coverage 70.48% 63.74% -6.75%
==========================================
Files 515 630 +115
Lines 23150 32447 +9297
==========================================
+ Hits 16317 20682 +4365
- Misses 5776 10178 +4402
- Partials 1057 1587 +530 ☔ View full report in Codecov by Sentry. |
Contributor
|
Hey @mboulton-fathom, thanks for opening this PR, the change looks good. Could you please rebase the PR? That should fix the failing tests. Thanks! 😄 |
There was a panic being caused in Logger.Stop() (Possibly from 97de7db) because threadLogsCancel might be nil if Stop was called before Start, this just initialises it to a noop function.
cc3eebf to
455b3d4
Compare
renzodavid9
approved these changes
Nov 14, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8949
Description
There was a panic being caused in
Logger.Stop()(Possibly from 97de7db) becausethreadLogsCancelmight be nil ifStopwas called beforeStart, this just initialises it to a noop function.