Merged
Conversation
Contributor
dgageot
commented
Aug 22, 2018
dgageot
commented
- Simplify the code: we don't need to reconnect the watch if we give a proper timeout.
- Fix a bug where we could miss a few logs. Add a few tests and comments.
Contributor
Author
|
ping @bobcatfish This comes from the discussion we've had on the code that prints the logs. |
Codecov Report
@@ Coverage Diff @@
## master #918 +/- ##
==========================================
+ Coverage 41.71% 41.91% +0.19%
==========================================
Files 61 61
Lines 2522 2522
==========================================
+ Hits 1052 1057 +5
+ Misses 1356 1351 -5
Partials 114 114
Continue to review full report at Codecov.
|
Signed-off-by: David Gageot <david@gageot.net>
Fix the code and add a few tests and comments. Signed-off-by: David Gageot <david@gageot.net>
r2d4
approved these changes
Aug 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.