fix: remove global helm flags from flags sent to skaffold filter#9212
Merged
renzodavid9 merged 2 commits intoGoogleContainerTools:mainfrom Dec 11, 2023
Merged
fix: remove global helm flags from flags sent to skaffold filter#9212renzodavid9 merged 2 commits intoGoogleContainerTools:mainfrom
skaffold filter#9212renzodavid9 merged 2 commits intoGoogleContainerTools:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9212 +/- ##
==========================================
- Coverage 70.48% 63.65% -6.83%
==========================================
Files 515 632 +117
Lines 23150 32545 +9395
==========================================
+ Hits 16317 20717 +4400
- Misses 5776 10236 +4460
- Partials 1057 1592 +535 ☔ View full report in Codecov by Sentry. |
cce6033 to
c3b5f86
Compare
c3b5f86 to
7c00572
Compare
ericzzzzzzz
approved these changes
Dec 11, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9124
Description
When using Skaffold's Helm deployer or renderer we invoke some helm commands with the
--post-rendererflag to invoke the Skaffold binary again triggering theskaffold filtercommand. We are sending thehelm.flags.globalvalues to the flags used byskaffold filter;helm.flags.globalis meant to be used in all the helm commands invoked by Skaffold, not inskaffold filter. Skaffold execution can fail because of this. This PR removes thehelm.flags.globalwhen runningskaffold filter.