chore: change bazel example#9218
Merged
ericzzzzzzz merged 4 commits intoGoogleContainerTools:mainfrom Dec 12, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9218 +/- ##
==========================================
- Coverage 70.48% 63.67% -6.82%
==========================================
Files 515 632 +117
Lines 23150 32545 +9395
==========================================
+ Hits 16317 20722 +4405
- Misses 5776 10232 +4456
- Partials 1057 1591 +534 ☔ View full report in Codecov by Sentry. |
Contributor
|
@ericzzzzzzz @renzodavid9 would it also make sense to remove this limitation on the target name? It was mostly due to skaffold/pkg/skaffold/build/bazel/build.go Lines 62 to 64 in c4af00e |
Contributor
Author
|
@ar3s3ru agree to remove the validation. |
renzodavid9
approved these changes
Dec 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.