Skip to content

fix: helm-deploy-chart-path-template#9243

Merged
ericzzzzzzz merged 2 commits intoGoogleContainerTools:mainfrom
ericzzzzzzz:helm-deploy-chartPath-template
Jan 8, 2024
Merged

fix: helm-deploy-chart-path-template#9243
ericzzzzzzz merged 2 commits intoGoogleContainerTools:mainfrom
ericzzzzzzz:helm-deploy-chartPath-template

Conversation

@ericzzzzzzz
Copy link
Copy Markdown
Contributor

@ericzzzzzzz ericzzzzzzz commented Jan 8, 2024

Fixes: #9198

@pull-request-size pull-request-size bot added size/S and removed size/L labels Jan 8, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 295 lines in your changes are missing coverage. Please review.

Comparison is base (290280e) 70.48% compared to head (4b7a89a) 63.62%.
Report is 1088 commits behind head on main.

Files Patch % Lines
cmd/skaffold/app/cmd/exec.go 16.32% 40 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/filter.go 47.27% 22 Missing and 7 partials ⚠️
cmd/skaffold/app/cmd/lsp.go 28.12% 23 Missing ⚠️
cmd/skaffold/app/cmd/verify.go 23.33% 23 Missing ⚠️
cmd/skaffold/app/cmd/fix.go 51.16% 17 Missing and 4 partials ⚠️
cmd/skaffold/app/cmd/inspect_job_manifest_paths.go 60.00% 15 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/inspect_namespaces.go 50.00% 13 Missing and 1 partial ⚠️
...md/skaffold/app/cmd/inspect_config_dependencies.go 45.83% 12 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/lint.go 42.85% 12 Missing ⚠️
cmd/skaffold/app/cmd/inspect_build_env.go 60.71% 11 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9243      +/-   ##
==========================================
- Coverage   70.48%   63.62%   -6.86%     
==========================================
  Files         515      632     +117     
  Lines       23150    32602    +9452     
==========================================
+ Hits        16317    20743    +4426     
- Misses       5776    10261    +4485     
- Partials     1057     1598     +541     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review January 8, 2024 18:16
@ericzzzzzzz ericzzzzzzz merged commit 64a69e2 into GoogleContainerTools:main Jan 8, 2024
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Templating for chartPath does not work

2 participants