feat(tar): added logs to CreateTar func#9271
Merged
ericzzzzzzz merged 3 commits intoGoogleContainerTools:mainfrom Jan 29, 2024
Merged
feat(tar): added logs to CreateTar func#9271ericzzzzzzz merged 3 commits intoGoogleContainerTools:mainfrom
ericzzzzzzz merged 3 commits intoGoogleContainerTools:mainfrom
Conversation
80c7ae6 to
00ef5e4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9271 +/- ##
==========================================
- Coverage 70.48% 63.64% -6.85%
==========================================
Files 515 632 +117
Lines 23150 32627 +9477
==========================================
+ Hits 16317 20765 +4448
- Misses 5776 10263 +4487
- Partials 1057 1599 +542 ☔ View full report in Codecov by Sentry. |
ericzzzzzzz
approved these changes
Jan 29, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Kaniko build can take more than 5 minutes while it creates a tar file and within the time you don't see any logs and you don't know what's going on, I think it'll be useful to show some progress so user can see that something is going on and you need to wait because sometimes I thought that it stuck while it's just trying to create a tar with a lot of files(more than 80k)
User facing changes

before(it took 4 minutes and I see no logs within the time):
after:
