Don't unmute logs if an error happened#928
Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom Sep 7, 2018
Merged
Don't unmute logs if an error happened#928dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #928 +/- ##
=========================================
- Coverage 43.55% 43.4% -0.16%
=========================================
Files 63 63
Lines 2645 2652 +7
=========================================
- Hits 1152 1151 -1
- Misses 1373 1379 +6
- Partials 120 122 +2
Continue to review full report at Codecov.
|
balopat
suggested changes
Aug 29, 2018
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
I would love to see a test case or two around this + see the nit comment.
pkg/skaffold/runner/runner.go
Outdated
| changed := changes{} | ||
| onChange := func() error { | ||
| logger.Mute() | ||
| unmute := true |
Contributor
There was a problem hiding this comment.
I would rename this to hasError, I think that would be more readable, what do you think?
Contributor
Author
There was a problem hiding this comment.
Yes, hasError is much better! I though I pushed this fix but I must have lost it.
dgageot
force-pushed
the
mute-errors
branch
2 times, most recently
from
73bfeb7 to
3033e69
Compare
balopat
approved these changes
Sep 5, 2018
Fix GoogleContainerTools#923 Signed-off-by: David Gageot <david@gageot.net>
When the skaffold configuration is changed, we Forgot to stop the logger before starting a new one. Signed-off-by: David Gageot <david@gageot.net>
Contributor
Author
|
Rebasing and making sure the kokoro tests pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not fully happy with the code because it introduces some duplication
But that could be dealt with in another PR
Fix #923
Signed-off-by: David Gageot david@gageot.net