chore: new googleCloudBuildRepoV2 field to configure a remote dependency#9293
Merged
renzodavid9 merged 4 commits intoGoogleContainerTools:mainfrom Feb 7, 2024
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9293 +/- ##
==========================================
- Coverage 70.48% 63.55% -6.94%
==========================================
Files 515 635 +120
Lines 23150 32804 +9654
==========================================
+ Hits 16317 20847 +4530
- Misses 5776 10348 +4572
- Partials 1057 1609 +552 ☔ View full report in Codecov by Sentry. |
61ed1d2 to
9de8a98
Compare
a65f10f to
cc16819
Compare
cc16819 to
b299793
Compare
ericzzzzzzz
approved these changes
Feb 7, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #9236
Description
requires[].googleCloudBuildRepoV2config key to allow a remote dependency configuration using Google Cloud Build Repositories V2oauth2format. Now the package defines the struct it accepts to download/sync a repo instead of using thelatest.GitInfofrom the yaml schema, leaving only the necessary fields it needsremote originURL before triggeringgit fetchandgit reset. This to handle the case when we useoauth2, the read token can expire, so we need to use the new one fetched from CBrequires[].googleCloudBuildRepoV2andrequires[].git, the generated folder name will be the same for both due to they use the same inputs to generate the hash (repo + ref). This shouldn't be a problem due to is the same source, and what will change is theremote originURL to use, or not, theoauth2formatskaffold renderto check that the remote dependency was fetched correctly