feat(exec|verify): enabled "namespace" option for exec and verify commands#9307
Merged
ericzzzzzzz merged 2 commits intoGoogleContainerTools:mainfrom May 8, 2024
Merged
feat(exec|verify): enabled "namespace" option for exec and verify commands#9307ericzzzzzzz merged 2 commits intoGoogleContainerTools:mainfrom
ericzzzzzzz merged 2 commits intoGoogleContainerTools:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9307 +/- ##
==========================================
- Coverage 70.48% 63.55% -6.93%
==========================================
Files 515 635 +120
Lines 23150 32804 +9654
==========================================
+ Hits 16317 20850 +4533
- Misses 5776 10346 +4570
- Partials 1057 1608 +551 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@ericzzzzzzz hi! Could you please review it? |
ericzzzzzzz
approved these changes
May 8, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9051
Description
Tested and enabled "--namespace" option for verify and exec commands
User facing changes
Before: no "--namespace" available for verify and exec commands
After: "--namespace" is available for verify and exec commands