Skip to content

Exclude helm dependency chart packages from watched files#932

Merged
dgageot merged 3 commits intoGoogleContainerTools:masterfrom
Uvedale:master
Sep 7, 2018
Merged

Exclude helm dependency chart packages from watched files#932
dgageot merged 3 commits intoGoogleContainerTools:masterfrom
Uvedale:master

Conversation

@Uvedale
Copy link
Copy Markdown
Contributor

@Uvedale Uvedale commented Aug 26, 2018

Fixes #931

This excludes files located in the charts subdirectory within a chart package from the list of watched files. This does mean that if someone manually does a helm dep update, the watcher won't pick up the change. However, a dependency version bump would require a change to requirements.yaml, which the watcher will detect.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 28, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@6ad057a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #932   +/-   ##
=========================================
  Coverage          ?   43.77%           
=========================================
  Files             ?       63           
  Lines             ?     2641           
  Branches          ?        0           
=========================================
  Hits              ?     1156           
  Misses            ?     1365           
  Partials          ?      120
Impacted Files Coverage Δ
pkg/skaffold/deploy/helm.go 63.58% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ad057a...c025a4b. Read the comment docs.

@dgageot
Copy link
Copy Markdown
Contributor

dgageot commented Aug 30, 2018

Thanks @Uvedale! could you add one or a few unit tests? That would be awesome!

@Uvedale
Copy link
Copy Markdown
Contributor Author

Uvedale commented Sep 3, 2018

Ok, I'll see what I can do.

@r2d4 r2d4 added the kokoro:run runs the kokoro jobs on a PR label Sep 3, 2018
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 3, 2018
@dgageot
Copy link
Copy Markdown
Contributor

dgageot commented Sep 5, 2018

@Uvedale If you don't have time to write the test, I'm happy to do it.

@Uvedale
Copy link
Copy Markdown
Contributor Author

Uvedale commented Sep 5, 2018

@dgageot I'll add the test(s) tonight. The last few days have been a bit hectic.

@dgageot dgageot merged commit ba4bf67 into GoogleContainerTools:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants