Exclude helm dependency chart packages from watched files#932
Merged
dgageot merged 3 commits intoGoogleContainerTools:masterfrom Sep 7, 2018
Merged
Exclude helm dependency chart packages from watched files#932dgageot merged 3 commits intoGoogleContainerTools:masterfrom
dgageot merged 3 commits intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
=========================================
Coverage ? 43.77%
=========================================
Files ? 63
Lines ? 2641
Branches ? 0
=========================================
Hits ? 1156
Misses ? 1365
Partials ? 120
Continue to review full report at Codecov.
|
Contributor
|
Thanks @Uvedale! could you add one or a few unit tests? That would be awesome! |
Contributor
Author
|
Ok, I'll see what I can do. |
Contributor
|
@Uvedale If you don't have time to write the test, I'm happy to do it. |
Contributor
Author
|
@dgageot I'll add the test(s) tonight. The last few days have been a bit hectic. |
dgageot
approved these changes
Sep 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #931
This excludes files located in the
chartssubdirectory within a chart package from the list of watched files. This does mean that if someone manually does ahelm dep update, the watcher won't pick up the change. However, a dependency version bump would require a change torequirements.yaml, which the watcher will detect.