Skip to content

fixes skaffold version in the released docker image#933

Merged
balopat merged 2 commits intoGoogleContainerTools:masterfrom
balopat:fix_release
Aug 29, 2018
Merged

fixes skaffold version in the released docker image#933
balopat merged 2 commits intoGoogleContainerTools:masterfrom
balopat:fix_release

Conversation

@balopat
Copy link
Copy Markdown
Contributor

@balopat balopat commented Aug 28, 2018

proof by manual testing, that I also added to the DEVELOPMENT.md

$ docker run gcr.io/<myproject>/skaffold:testrelease_v2 skaffold version
testrelease_v2

fixes #906.

@balopat balopat requested review from dgageot and r2d4 as code owners August 28, 2018 21:33
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 28, 2018

Codecov Report

Merging #933 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #933   +/-   ##
=======================================
  Coverage   43.58%   43.58%           
=======================================
  Files          62       62           
  Lines        2611     2611           
=======================================
  Hits         1138     1138           
  Misses       1354     1354           
  Partials      119      119

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea1e93...06dde15. Read the comment docs.

@balopat balopat added the wip label Aug 28, 2018
@balopat balopat removed the wip label Aug 28, 2018
@balopat balopat merged commit 055f6f9 into GoogleContainerTools:master Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

published image version is still wrong

3 participants