fix: add --load flag for local buildkit#9387
Merged
ericzzzzzzz merged 2 commits intoGoogleContainerTools:mainfrom Apr 17, 2024
Merged
fix: add --load flag for local buildkit#9387ericzzzzzzz merged 2 commits intoGoogleContainerTools:mainfrom
ericzzzzzzz merged 2 commits intoGoogleContainerTools:mainfrom
Conversation
Adds the --load flag when building images using buildkit, and not pushing to a remote registry. This is required, to get them loaded into the local docker context.
Adds testing to ensure that the --load flag is applied correctly.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
Hi @Crystalix007 Thank you for the contribution! The change looks good, but skaffold integration test infra seems broken at the moment, we'll merge the change after the issue is fixed. |
ericzzzzzzz
approved these changes
Apr 15, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the --load flag when building images using buildkit, and not pushing to a remote registry.
This is required, to get them loaded into the local docker context.
User facing changes (remove if N/A)
Before:
Running
devcomplained with:After: