Skip to content

feat(git): added commit hash support to git.ref#9430

Merged
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
idsulik:issue-7018
Aug 29, 2024
Merged

feat(git): added commit hash support to git.ref#9430
ericzzzzzzz merged 1 commit intoGoogleContainerTools:mainfrom
idsulik:issue-7018

Conversation

@idsulik
Copy link
Copy Markdown
Contributor

@idsulik idsulik commented May 29, 2024

Fixes: #7018

Description
Added commit hash support to git.ref

User facing changes
before: no hash support for git.ref.
after: git.ref supports commit hash.

example:

apiVersion: skaffold/v4beta11
kind: Config
requires:
- git:
    repo: https://github.com/GoogleContainerTools/skaffold
    ref: f386e6c552e83c3a9445fe34442aaed8dd381ab3
    path: examples/multi-config-microservices/leeroy-app
    sync: false

@idsulik
Copy link
Copy Markdown
Contributor Author

idsulik commented Aug 22, 2024

Hi @ericzzzzzzz ,

I noticed that this pull request has been pending for a while. Is there anything more needed from my side? Please let me know if there are any updates or additional changes required.

Thanks!

@ericzzzzzzz ericzzzzzzz merged commit d8ca62c into GoogleContainerTools:main Aug 29, 2024
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Required configs in git repositories cannot be referenced by commit or tag

2 participants