chore: upgrade more dependencies#9617
Conversation
some YAML library changed how it indents lists
the godotenv parser is a little more liberal in what it parses, so we have to make our malformed test case a little extra malformed
A change in kustomize meant that when you import its YAML libraries, you get a repackaged version of yaml.v3 instead of the real ones. This broke YAML parsing in a very confusing way. Specifically, UnmarshalClusterVolumes no longer implemented yaml.v3/Unmarshaller. Instead it implemented sigs.k8s.io/yaml/goyaml.v3/Unmarshaller. Which means the YAML parser just never bothered to call our custom Unmarshaller logic. None of this is particularly interesting, but it took me at least 8 hours to figure it out, so I wanted to write it down.
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Hi @plumpy, code-review-assist is currently reviewing this pull request and will post a full review in a few minutes. In the meantime, here's a quick summary for you and other reviewers:
This pull request upgrades several dependencies. The changes involve adding or updating license files for various dependencies, including mergo, kaniko, heredoc, sprig, go-crypto, purell, levenshtein, semver, circl, containerd/log, containerd/platforms, containerd/typeurl, json-canonicalization, filepath-securejoin, distribution/reference, docker/cli, httpsnoop, jwt-go, cbor, go-chi/chi, here, safetext, gnostic, gorilla/mux, and gorilla/websocket. Additionally, there are some internal changes to the hcl decoder to handle duplicate attribute keys.
One small change to the docker/cli NOTICE file updates a URL to use see instead of please see.
Happy reviewing!
Dependencies rise,
Licenses updated, all in sight,
Code flows anew.
|
Gemini encountered an error creating the review. You can try again by commenting |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9617 +/- ##
==========================================
- Coverage 70.48% 63.15% -7.34%
==========================================
Files 515 648 +133
Lines 23150 33607 +10457
==========================================
+ Hits 16317 21223 +4906
- Misses 5776 10728 +4952
- Partials 1057 1656 +599 ☔ View full report in Codecov by Sentry. |
plumpy
requested review from
mattsanta and
menahyouyeah
and removed request for
menahyouyeah
2 participants
No description provided.